Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ims_qos: check and log for NULL sessionId #3503

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Conversation

smititelu
Copy link
Contributor

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Check for NULL sessionId from PCRF, which can lead to kamailio crash.

@miconda
Copy link
Member

miconda commented Jul 4, 2023

Thanks!

@miconda miconda merged commit 1b29131 into kamailio:master Jul 4, 2023
8 checks passed
@smititelu
Copy link
Contributor Author

can I backport this to 5.7 and 5.6?

@henningw
Copy link
Contributor

henningw commented Jul 5, 2023

It is a bugfix, sure. Small note regarding future patches, its actually not necessary to include the function name prefix in the log message, it should be added automatically from the LM_ERR etc.. macros.

@smititelu
Copy link
Contributor Author

OK, thank you.

henningw added a commit that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants