Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jwt: build jwt module for debian distributions #3556

Closed
wants to merge 1 commit into from
Closed

Conversation

eschmidbauer
Copy link
Contributor

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

I am not very familiar with the build/packaging process but I'm hoping we can get jwt module packaged for debian since the dependencies (libjwt) already ship with most recent debian distributions. Any feedback would be appreciated here, thanks.

@eschmidbauer
Copy link
Contributor Author

@linuxmaniac
From the build pipeline:
image

Can we update the docker container to include libjwt-dev ?

@miconda
Copy link
Member

miconda commented Sep 4, 2023

Hopefully Debain 12 has the required version, iirc Debian 11 has libjwt 1.10.0, which is too old, the module needs 1.12.0.

@eschmidbauer
Copy link
Contributor Author

eschmidbauer commented Sep 4, 2023

Hopefully Debain 12 has the required version, iirc Debian 11 has libjwt 1.10.0, which is too old, the module needs 1.12.0.

looks like libjwt-dev is still packaged with version1.10.2 on debian bookworm :(
closing this PR

@miconda
Copy link
Member

miconda commented Sep 4, 2023

Oh, that's bad, I hoped Deb 12 has the newer version. Not sure what would take to make the module compile with older version, but I think there were constraints that I needed to use libjwt 1.12.0.

@henningw
Copy link
Contributor

henningw commented Sep 5, 2023

Just for reference, this seems to be the difference between 1.10.2 and 1.12.0: link
Its not a small diff, 3,077 additions and 115 deletions.

@eschmidbauer eschmidbauer deleted the build-jwt branch September 5, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants