Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: add example script to create tarball with submodules instantiated #3590

Merged
merged 2 commits into from Oct 6, 2023

Conversation

space88man
Copy link
Contributor

@space88man space88man commented Oct 5, 2023

In preparation for packaging of tls_wolfssl, add an example script to create source tarball with submodule code.

  • add mock configs and instructions for packaging locally
  • add convenience script to create a src.rpm

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

In preparation for packaging tls_wolfssl the distributed source tarballs need to have the submodule instantiated and archived with the primary source code. This is an example script to package submodule code with the primary code.

It can be used in CI/CD to prepare the tarball.

Subsequently I will update the pkg/ scripts to enable packaging of tls_wolfssl.

Pinging @sergey-safarov.

@space88man space88man force-pushed the pkg-submodule branch 3 times, most recently from 9d1e91c to e2beb5c Compare October 5, 2023 05:30
@miconda
Copy link
Member

miconda commented Oct 5, 2023

If reusing misc/scripts/ location does not seem a good option, I think it is better at least to have the folder relocated to pkg/kamailio/scripts/ instead of pkg/scripts/.

@space88man
Copy link
Contributor Author

space88man commented Oct 5, 2023

If reusing misc/scripts/ location does not seem a good option, I think it is better at least to have the folder relocated to pkg/kamailio/scripts/ instead of pkg/scripts/.

Done and pushed.

Update: rebased to @ f04f853

In preparation for packaging of tls_wolfssl, add an example script to
create source tarball with submodule code.
This mock config can be used to build RPM packages from a kamailio src.rpm.
- update pkg/kamailio/obs/README -> README.md to include mock
  instructions
- add script create-src-rpm.sh to create src.rpm for package
  building
@miconda
Copy link
Member

miconda commented Oct 6, 2023

Thanks!

@miconda miconda merged commit 9de780b into kamailio:master Oct 6, 2023
8 checks passed
@space88man space88man deleted the pkg-submodule branch October 6, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants