Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make timeout mechanism useful by adding support for supplying timeout tag #3598

Closed
wants to merge 2 commits into from
Closed

Make timeout mechanism useful by adding support for supplying timeout tag #3598

wants to merge 2 commits into from

Conversation

sobomax
Copy link
Contributor

@sobomax sobomax commented Oct 10, 2023

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

The timeout_socket feature has been added in 2010, but from the look of it it has been designed for the "ngcp-mediaproxy-ng" and never worked with the real RTPProxy. As such both the documentation and the code needs to be adjusted to make it actually useful with the RTPProxy.

@sobomax
Copy link
Contributor Author

sobomax commented Oct 16, 2023

The check fails due to unrelated issue:

A fatal error occurred: Could not write a relation to a file (eventual cause: IOException "No space left on device") Error: Error running analysis for cpp: Encountered a fatal error while running "/opt/hostedtoolcache/CodeQL/2.15.0/x64/codeql/codeql database run-queries --ram=5897 --threads=2 /home/runner/work/_temp/codeql_databases/cpp --min-disk-free=1024 -v --expect-discarded-cache --no-intra-layer-parallelism". Exit code was 2 and error was: A fatal error occurred: Could not write a relation to a file (eventual cause: IOException "No space left on device"). See the logs for more details.

@miconda
Copy link
Member

miconda commented Oct 19, 2023

Thanks!

Is the PR completed? If yes, I would merge it manually to make the commit message follow the contributing guidelines:

@sobomax
Make timeout notification feature useable.
fdb1d7c 
Add an new "timeout_tag_pv" option to set notify tag along
with the notification socket path. Both are required by the
RTPProxy.

Reported by:	James Lipski <jameslipski@protonmail.com>
@sobomax
Update rtpproxy module documentation.
b54bca5 
o Correct description of the timeout_socket;

o Document timeout_tag_pv;

o Update (c);

o Remove reference to the ngcp-mediaproxy-ng which does not exist
  anymore.
@sobomax
Copy link
Contributor Author

sobomax commented Oct 19, 2023

Thanks!

Is the PR completed? If yes, I would merge it manually to make the commit message follow the contributing guidelines:

Hi Daniel, yes, it's complete. Thanks for pointing out, I've updated the commit messages to hopefully conform to the guidelines.

@linuxmaniac
Copy link
Member

amended the commit messages to use rtpproxy: as prefix. Thanks!
8ac5709
190ef9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sobomax @miconda @linuxmaniac