Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_client: add information about parameter loading #3619

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

tietzsg
Copy link
Contributor

@tietzsg tietzsg commented Oct 27, 2023

  • Inform that the order of the parameters is important when httpcon is loaded first

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

- Inform that the order of the parameters is important when httpcon is loaded first
@nchaigne
Copy link
Contributor

The behaviour is actually documented:
"The HTTP connection will be defined using default values in modparam's above the definition of the httpcon in the configuration file."

But this can easily be overlooked. I also had trouble understanding why my configuration did not work initially.
It's better to be more explicit as you propose.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typos : "paramters", "cirtificates"

@miconda miconda merged commit 02dd4e2 into kamailio:master Nov 2, 2023
4 checks passed
miconda pushed a commit that referenced this pull request Nov 13, 2023
* http_client: add information about parameter loading

- Inform that the order of the parameters is important when httpcon is loaded first

* http_client: docs - typos from previous commit

---------

Co-authored-by: Daniel-Constantin Mierla <miconda@gmail.com>
(cherry picked from commit 02dd4e2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants