Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed saving dialogs on shutdown that are already loaded at startup in db_mode 3 #3688

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Fixed saving dialogs on shutdown that are already loaded at startup in db_mode 3 #3688

merged 1 commit into from
Dec 28, 2023

Conversation

Den4t
Copy link
Contributor

@Den4t Den4t commented Dec 22, 2023 •
edited

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

Description

@Den4t
Copy link
Contributor Author

Den4t commented Dec 22, 2023 •
edited

Some incorrect indentation was found after initial commit, fixed in additional commits.

@linuxmaniac
Copy link
Member

You have to squash them in one single commit and push force it

@Den4t
dialog: fixed saving dialogs on shutdown that are already loaded at s…
ecaeb2a 
…tartup when using db_mode 3

- The dialogs that loaded at startup are not saved in DB on shutdown, and so not loaded at restart,
  fixes issue #3669
@Den4t
Copy link
Contributor Author

Den4t commented Dec 26, 2023

Done

@miconda
Copy link
Member

miconda commented Dec 28, 2023

Thanks!

@miconda miconda merged commit 2d00ce5 into kamailio:master Dec 28, 2023
4 checks passed
@Den4t Den4t deleted the dlg branch December 31, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Den4t @linuxmaniac @miconda