Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ims_ipsec_pcscf: reset destination URI after value is used to decide … #3689

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

herlesupreeth
Copy link
Contributor

@herlesupreeth herlesupreeth commented Dec 24, 2023

…destination protocol to use

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

This commits rearranges the place where destination URI is resetted (based on the flag). This change was needed because the value was used to decide destination protocol to use.

@herlesupreeth
Copy link
Contributor Author

Looks like CI is failing due to some missing module (auth_identity), which is not part of my merge request. Can someone please take a look?

@miconda
Copy link
Member

miconda commented Dec 28, 2023

Thanks!

@miconda miconda merged commit 75de09f into kamailio:master Dec 28, 2023
4 checks passed
@herlesupreeth herlesupreeth deleted the fix_resetting_dest_uri branch January 10, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants