Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pv_core: Fix negative index bug for hfl() #3697

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

xkaraman
Copy link
Contributor

@xkaraman xkaraman commented Jan 4, 2024

Before: -1 yielded null and -2 the last element of a header

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

Description

This PR fixes a bug referenced in #3653.

Before fix $(hfl(HEADER)[-1] where HEADER='Via' | Contact | Route | Record-Route produced null instead of the last element of header.

Before: -1 yielded null and -2 the last element of a header
@miconda
Copy link
Member

miconda commented Jan 5, 2024

Thanks!

I thought it was based on the same approach as for $(hdr(name)[index]), but that works fine.

@miconda miconda merged commit 8038fba into kamailio:master Jan 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants