Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_async_client: exit mod_init if tm is not loaded #3706

Merged
merged 1 commit into from
Jan 10, 2024
Merged

http_async_client: exit mod_init if tm is not loaded #3706

merged 1 commit into from
Jan 10, 2024

Conversation

grumvalski
Copy link
Contributor

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

@henningw henningw merged commit 5a40d1e into master Jan 10, 2024
4 checks passed
@henningw
Copy link
Contributor

Thanks for the PR, merged

dilyanpalauzov
dilyanpalauzov reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@dilyanpalauzov dilyanpalauzov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the line above LM_ERROR is bettet than LM_INFO.

src/modules/http_async_client/http_async_client_mod.c
@@ -295,7 +295,7 @@ static int mod_init(void)

if(load_tm_api(&tmb) < 0) {
LM_INFO("cannot load the TM-functions - async relay disabled\n");
memset(&tmb, 0, sizeof(tm_api_t));
return -1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the line above LM_ERROR is bettet than LM_INFO.

henningw added a commit that referenced this pull request Jan 11, 2024
@henningw
http_async_client: use error log level (GH #3706)
72595fe
@henningw
Copy link
Contributor

@dilyanpalauzov You are right, done in the commit above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilyanpalauzov dilyanpalauzov dilyanpalauzov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grumvalski @henningw @dilyanpalauzov