Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acc_radius : added radius time mode #378

Merged
merged 3 commits into from Oct 26, 2015
Merged

Conversation

ycaner06
Copy link
Contributor

added radius time mode for new event-timestamp . Format is seconds.microseconds

added radius time mode for new event-timestamp . Format is seconds.microseconds
@miconda
Copy link
Member

miconda commented Oct 23, 2015

Printing the float is not having any safety:

sprintf(smicrosec,"%f",tsecmicro);

Variable smicrosec has the size 18, I assume you wanted to have 10digits . 6digits, but then enforce it because %f can have exponential representation, where the lenght can differ from system to system. Use:

sprintf(smicrosec,"%17.6f",tsecmicro);

Push this as an extra patch to your branch to show in pull request. Also, add the documentation and the PR will be merged.

@ycaner06
Copy link
Contributor Author

Thanks Daniel. I will handle it.

@ycaner06 ycaner06 closed this Oct 26, 2015
@miconda
Copy link
Member

miconda commented Oct 26, 2015

You don't need to create a new complete path (pull request or branch) -- a second commit pushed in the same branch for this pull request will do it. Then you can have another patch to add the docs -- all will show up here if you reuse the same branch.

Yasin CANER added 2 commits October 26, 2015 15:49
fixed exponential representation in converting
added  information about new mod paramaeter rad_time_mode
@ycaner06
Copy link
Contributor Author

Really sorry Daniel. i spending your time this stuffs Because I am rookie for C and GitHub. i committed changes to patch-7.

@ycaner06 ycaner06 reopened this Oct 26, 2015
@miconda
Copy link
Member

miconda commented Oct 26, 2015

Thanks. It will be merged.

miconda added a commit that referenced this pull request Oct 26, 2015
acc_radius : added radius time mode
@miconda miconda merged commit 1399978 into kamailio:master Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants