Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcp/docs: Added tcp_accept_iplimit config sample #3792

Closed
wants to merge 1 commit into from

Conversation

arnivoit
Copy link

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

We noticed that configuration option tcp_accept_iplimit was included in newer kamailio versions (most notably 5.7.4), and it was a breaking change for us. Added sample configuration value in /etc/kamailio.cfg file - already tested in our production deployment.

@henningw
Copy link
Contributor

Looks good to me, its also just a comment in the end. Lets wait a bit more for feedback and then merge it.

@miconda
Copy link
Member

miconda commented Apr 11, 2024

Fine for me to add it to the default config file etc/kamailio.cfg, but the commit message should be updated to reflect that, not the prefix tcp/docs: is not suggesting at all it is about etc/kamailio.cfg.

@henningw
Copy link
Contributor

Thanks, it was merged manually due to a wrong commit message.

@henningw henningw closed this Apr 16, 2024
@henningw
Copy link
Contributor

commit 30a0fe2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants