Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cfgutils lock #3808

Merged
merged 3 commits into from
Apr 15, 2024
Merged

cfgutils lock #3808

merged 3 commits into from
Apr 15, 2024

Conversation

linuxmaniac
Copy link
Member

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally

Description

expose in config via cfgutils core_case_hash optional second string key for hashing

@miconda
Copy link
Member

miconda commented Apr 11, 2024

I have nothing explicitly against this enhancement, but I guess that if one wanted to have two strings to compose the lock key, then could use lock("$var(str1)$var(str2)") as alternative to new variant lock("$var(str1)", "$var(str2)"). The hashing behind is probably not the same result, but from the perspective of taking in consideration two strings for hashing, should be a similar behaviour.

@linuxmaniac linuxmaniac merged commit 92ac41c into master Apr 15, 2024
4 checks passed
@linuxmaniac linuxmaniac deleted the vseva/cfgutils_lock branch April 15, 2024 08:50
linuxmaniac added a commit to kamailio/kamailio-wiki that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants