-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tm: add mandatory Max-Forwards header to local ACK #3856
Conversation
Remember that the git commit message first line has to be formatted as per contributing guidelines, it has to be prefixed with the component name: The commit messages are used for generating the changelog for releases as well as making easier to figure out what was impacted by a commit. Having the commit message in the proper format makes it easier to merge as well directly from the git PR portal. |
Same checks bug as earlier: according to Details, check-format PASSED, but there still claim that |
@juha-h is not a bug. The format checks each commit. I already told you how to properly do it. Just create one commit with the proper commit message prefix squashing both previous commits in the branch. |
Victor Seva writes:
Just create one commit with the proper commit message prefix squashing
both previous commits in the branch.
Goes beyond me. In baresip project, nothing like that needs to be
done. If there is new commit to PR, all checks are automatically
re-run.
|
juha-h writes:
Goes beyond me. In baresip project, nothing like that needs to be
done. If there is new commit to PR, all checks are automatically
re-run.
... and red marks turn green without any extra action.
|
since it's a branch in kamailio repo I did it myself.
squashed both commits and added the tm prefix |
The idea behind it's that all commits are properly formatted. |
Is it OK to cherry-pick this to 5.8 branch? |
Yes, it can be cherry-picked, it is about a mandatory header. |
Daniel-Constantin Mierla writes:
Yes, it can be cherry-picked, it is about a mandatory header.
Done.
|
Type Of Change
Checklist:
Description
Add mandatory Max-Forwards header to local ACK