Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth_radius: support for not appending realm to the username passed to RADIUS #456

Closed
wants to merge 1 commit into from
Closed

auth_radius: support for not appending realm to the username passed to RADIUS #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/auth_radius/authrad_mod.c
View file
Open in desktop
Expand Up @@ -66,6 +66,7 @@ static int service_type = -1;

int use_ruri_flag = -1;
int ar_radius_avps_mode = 0;
int append_realm_to_username = 1;

static char *auth_extra_str = 0;
struct extra_attr *auth_extra = 0;
Expand Down Expand Up @@ -95,6 +96,7 @@ static param_export_t params[] = {
{"use_ruri_flag", INT_PARAM, &use_ruri_flag },
{"auth_extra", PARAM_STRING, &auth_extra_str },
{"radius_avps_mode", INT_PARAM, &ar_radius_avps_mode },
{"append_realm_to_username", INT_PARAM, &append_realm_to_username },
{0, 0, 0}
};

Expand Down
1 change: 1 addition & 0 deletions modules/auth_radius/authrad_mod.h
View file
Open in desktop
Expand Up @@ -41,6 +41,7 @@ extern struct extra_attr *auth_extra;

extern int use_ruri_flag;
extern int ar_radius_avps_mode;
extern int append_realm_to_username;

extern auth_api_s_t auth_api;

Expand Down
5 changes: 5 additions & 0 deletions modules/auth_radius/doc/auth_radius.xml
View file
Open in desktop
Expand Up @@ -38,6 +38,11 @@
<surname>Janak</surname>
<email>jan@iptel.org</email>
</editor>
<editor>
<firstname>Phil</firstname>
<surname>Lavin</surname>
<email>phil.lavin@synety.com</email>
</editor>
</authorgroup>
<copyright>
<year>2002</year>
Expand Down
17 changes: 17 additions & 0 deletions modules/auth_radius/doc/auth_radius_admin.xml
View file
Open in desktop
Expand Up @@ -205,6 +205,23 @@ modparam("auth_radius", "radius_avps_mode", 1)
</programlisting>
</example>
</section>
<section id="auth_radius.p.append_realm_to_username">
<title><varname>append_realm_to_username</varname> (integer)</title>
<para>
If set to 1, the username passed to the RADIUS server will have the
digest realm appended to it, if no domain is provided in the digest
username.
</para>
<para>
Default value is 1.
</para>
<example>
<title><varname>append_realm_to_username</varname> parameter usage</title>
<programlisting format="linespecific">
modparam("auth_radius", "append_realm_to_username", 0)
</programlisting>
</example>
</section>
</section>

<section>
Expand Down
2 changes: 1 addition & 1 deletion modules/auth_radius/sterman.c
View file
Open in desktop
Expand Up @@ -243,7 +243,7 @@ int radius_authorize_sterman(struct sip_msg* _msg, dig_cred_t* _cred, str* _meth
* Add all the user digest parameters according to the qop defined.
* Most devices tested only offer support for the simplest digest.
*/
if (_cred->username.domain.len) {
if (_cred->username.domain.len || !append_realm_to_username) {
if (!rc_avpair_add(rh, &send, attrs[A_USER_NAME].v, _cred->username.whole.s, _cred->username.whole.len, 0)) {
LM_ERR("unable to add User-Name attribute\n");
goto err;
Expand Down