srutils: change names colliding with libcrypto #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, it can be merged. |
camilleoudot
added a commit
that referenced
this pull request
Feb 19, 2016
srutils: change names colliding with libcrypto
|
Should this be back ported? |
|
You're right, the bug should occur every time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kamailio's srutils SHA functions have names that collide with OpenSSL's libcrypto SHA functions.
In practice, OpenSSL fails to validate a server cert if srutils is loaded before libcrypto, because their SHA functions are not 100% equivalent.
On my Debian, http_async_client was unable to issue any HTTPS request unless server certificate verification was disabled.
This patch solves the issue by renaming the SHA functions in srutils to non-colliding names. I think this has no side effect because they are only used internally.