kex: Call pkg_proc_update_stats only when needed #567
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a patch for 4.1 which allows to display also the total number of pkg fragments upon calling
kamcmd pkg.stats
, inspiring myself from the latest upstream. This PR comes as a result to enabling MALLOC_STATS and noticing kamailio slowdown with my applied patch, for 4.1. The slowdown was happening because each time a memory function was called, iteration through all fragments happened uponpkg_info
. The solution was to call the stats gathering only when kamcmd command is issued.On master this slowdown is not happening anymore, because
qm->ffrags
variable counts the fragments "on the fly", while memory functions are called. Still, is it necessarily to call pkg_proc_update_stats() callback every time?!Feel free to close this if not needed.