Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/kamailio/deb: use libradcli-dev for radius #595

Merged
merged 3 commits into from May 10, 2016

Conversation

linuxmaniac
Copy link
Member

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=822338

kamailio-radius-modules depends on libfreeradius-client
libfreeradius-client has been deprecated in favor of radcli[1]

@linuxmaniac linuxmaniac self-assigned this May 3, 2016
@linuxmaniac linuxmaniac added the 4.4 label May 3, 2016
@miconda
Copy link
Member

miconda commented May 3, 2016

So no changes required to radius modules -- only to pkg specs, right?

The PR can be merged. Thanks.

@linuxmaniac
Copy link
Member Author

Still under testing

@linuxmaniac
Copy link
Member Author

linuxmaniac commented May 6, 2016

So no changes required to radius modules -- only to pkg specs, right?

Sadly, no. The Debian package doesn't provide the compatible include files freeradius-client.h nor radiusclient-ng.h, so we have two options:

  1. remove radiusclient-ng support and use radcli instead
  2. use another define to select the proper radius library ( RADCLI ?)

@miconda
Copy link
Member

miconda commented May 6, 2016

A define is better because the radiusclient-ng is the only one available in some (old) OSes.

@amessina
Copy link
Contributor

amessina commented May 7, 2016

Reporting in... For Fedora 23, the following can be accomplished with just a spec file change:

%package radius
Summary: Radius AAA API for Kamailio
Group: Applications/Internet
Requires: kamailio = %{version}-%{release}
#Requires: radiusclient-ng
#BuildRequires: radiusclient-ng-devel
Requires: radcli
BuildRequires: radcli-compat-devel

@linuxmaniac
Copy link
Member Author

A define is better because the radiusclient-ng is the only one available in some (old) OSes.

defined RADCLI

@linuxmaniac
Copy link
Member Author

@miconda can this changes be included in 4.4.1?

@miconda
Copy link
Member

miconda commented May 10, 2016

Yes, please.

@linuxmaniac linuxmaniac merged commit f6186d7 into kamailio:master May 10, 2016
@linuxmaniac linuxmaniac deleted the vseva/radius branch May 10, 2016 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants