auth: Add option to use SHA-256 instead of MD5 in digest authentication #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 13, 2016 11:39
…stead of MD5 for digest authentication.
The module paramter "algorithm" was added with the possible values "", "MD5" or "SHA-256". It allows chosing between MD5 or SHA-256 hash algorithm for digest authentication. The configured algorithm is advertised in the challenge header. The default values is "" which omits the algorithm field in the challenge header and uses MD5 for digest authentication.
|
Thanks for the contribution! Looking at the sequence of operations, only the patch 4a076a0 needs to be reviewed and merged, right? |
|
Hi. Yes, only patch 4a076a0 is relevant. |
|
Hi. Did anyone look at the proposed feature ? Regards, |
|
These days many of us are at Kamailio World Conference in Berlin, therefore some low activity around the online resources of the project. This looks like something I will have to review, but being one of the organizers these days I don't have much time to even breed. However, I will try to do it soon. |
|
Ok, no problem. |
miconda
pushed a commit
that referenced
this pull request
May 23, 2016
…hentication - the module paramter "algorithm" was added with the possible values "", "MD5" or "SHA-256". - it allows chosing between MD5 or SHA-256 hash algorithm for digest authentication. - the configured algorithm is advertised in the challenge header. - the default values is "" which omits the algorithm field in the challenge header and uses MD5 for digest authentication. - submitted via GH pull request #628
|
Thanks, the patch was pushed manually on your behalf with commit e7faf1e . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative solution to pull request: #627