Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix regex error for modules parameters #703

Merged
merged 1 commit into from Jul 11, 2016

Conversation

snen
Copy link
Contributor

@snen snen commented Jul 9, 2016

Ambiguous was possible in params for multiple modules in one config line.
For example

loadmodule "presence_dialoginfo.so"
modparam("presence|dialplan", "db_url", "mysql://DBUSER:DBPASSWORD@localhost/DBNAME")

produced error
parameter <db_url> of type <1> not found in module <presence_dialoginfo>
because of ["presence_dialoginfo" =~ /^presence|dialplan$/] => True

@miconda
Copy link
Member

miconda commented Jul 10, 2016

The size in pkg_malloc() needs to be increased, too -- from:

    reg = pkg_malloc(len + 2 + 1);

to:

    reg = pkg_malloc(len + 4 + 1);

Ambiguous was possible in params for multiple modules in one config line.
@snen snen force-pushed the module_parameter_regexp_fix branch from 01966de to 198b116 Compare July 10, 2016 14:39
@snen
Copy link
Contributor Author

snen commented Jul 10, 2016

right you are!
changed

@miconda miconda merged commit fb36994 into kamailio:master Jul 11, 2016
@snen snen deleted the module_parameter_regexp_fix branch July 11, 2016 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants