ims_qos: create a proper flow description for the SIP signaling #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- before there was just an empty one in the AAR - re-using the function typically used for the RTP media - fixing then that function to not just hard-code protocol 17 (UDP) for everything - now supporting also 6 (TCP) and IP (IP has no protocol number, we use just the magic word "ip" (see RFC 3588 IPFilterRule for more details) - adding the IP of the P-CSCF as a parameter to the module, as this is required in the flow (UE IP <-> P-CSCF IP) - also some inline/static fixes to function for avoiding warnings on gcc >=5
|
Will complete with or more fix to the ims_registrar_pcscf module and then request again (sorry for the spam) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
magic word "ip" (see RFC 3588 IPFilterRule for more details)
in the flow (UE IP <-> P-CSCF IP)