registrar: Fix check of contact length and make it configurable #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 26, 2016 08:41
…jected Added some warnings in case a REGISTER is rejected because of an invalid contact header field. Before, kamailio might answer a 400 Bad Request for a too long contact URI for example without logging any message.
The URI size of contacts is checked against a max size to ensure that it fits into the database column. This check was already present before but was done only for the contact header fields other than the first header field which made that REGISTER with a single contact were not checked for max size and were truncated later when stored to the database. With this fix all contact URIs of all contact header fields are checked against the max size.
…t size configurable The new module parameter "contact_max_size" allows changing the max size of contact URIs that are accepted in REGISTER requests. The default value of this parameter is 255 which was the value of the compile time constant that is replaced by this module parameter. If configured one must make sure that the DB actually supports the configured size in the column "contact".
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split the pull request in three commits to seperate the fix from the new feature, but they go together so I propose them in the same pull request:
cc0b07d: I added some log message that would have helped me to understand a 400 Bad Request response.
c0697d7: I fixed a bug that were the contact size is not checked on the first header field and 200 OK is sent instead of 400 Bad Request for too long contact URIs but the uri ends up beein truncated by the database.
eb6b9c6: I made the contact size configurable to allow longer contacts