Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/sctp - Fixes FreeBSD compile error and 2 warnings #74

Closed
wants to merge 1 commit into from

Conversation

mslehto
Copy link
Member

@mslehto mslehto commented Feb 9, 2015

This patch makes SCTP module compile without errors or warnings on FreeBSD 10.1

CC (clang) [M sctp.so]          sctp_server.o
sctp_server.c:2400:54: error: too few arguments provided to function-like macro invocation
                        SCTP_EV_REMOTE_ERROR(&si->address, si->port_no, su);
                                                                          ^
./sctp_ev.h:37:9: note: macro 'SCTP_EV_REMOTE_ERROR' defined here
#define SCTP_EV_REMOTE_ERROR(lip, lport, src, err)
        ^
sctp_server.c:2400:4: error: use of undeclared identifier 'SCTP_EV_REMOTE_ERROR'
                        SCTP_EV_REMOTE_ERROR(&si->address, si->port_no, su);
                        ^
sctp_server.c:2662:13: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
                if ((errno==ENOENT)){

sctp_server.c:2829:13: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
                if ((errno==ENOENT)){

CC (clang) [M sctp.so]          sctp_server.o
sctp_server.c:2400:54: error: too few arguments provided to function-like macro invocation
                        SCTP_EV_REMOTE_ERROR(&si->address, si->port_no, su);
                                                                          ^
./sctp_ev.h:37:9: note: macro 'SCTP_EV_REMOTE_ERROR' defined here
#define SCTP_EV_REMOTE_ERROR(lip, lport, src, err)
        ^
sctp_server.c:2400:4: error: use of undeclared identifier 'SCTP_EV_REMOTE_ERROR'
                        SCTP_EV_REMOTE_ERROR(&si->address, si->port_no, su);
                        ^
sctp_server.c:2662:13: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
                if ((errno==ENOENT)){

sctp_server.c:2829:13: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
                if ((errno==ENOENT)){
@miconda
Copy link
Member

miconda commented Feb 10, 2015

I pushed the patch manually, with you as author -- the commit message was not appropriate for the changelog style, changed that to something more human friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants