RPC fix for arrays on permissions module

[kelchy]

subnet dump and address dump

[miconda]

Can you try by setting RET_ARRAY flag to RPC exports at:

• https://github.com/kamailio/kamailio/blob/master/modules/permissions/permissions.c#L1015

Like at:

• https://github.com/kamailio/kamailio/blob/master/modules/corex/corex_rpc.c#L227

If works, it should be the desired implementation in such case.

Also, for the future, first line of the commit must be prefixed with the module name, see:

• https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format

[kelchy]

Kelvin Chua

On Fri, Aug 19, 2016 at 2:24 AM, Daniel-Constantin Mierla <
notifications@github.com> wrote:

Can you try by setting RET_ARRAY flag to RPC exports at:

• https://github.com/kamailio/kamailio/blob/master/modules/
  permissions/permissions.c#L1015
  https://github.com/kamailio/kamailio/blob/master/modules/permissions/permissions.c#L1015

tried it, it changes the root but still returns 1 array element

Like at:

• https://github.com/kamailio/kamailio/blob/master/modules/
  corex/corex_rpc.c#L227

If works, it should be the desired implementation in such case.

Also, for the future, first line of the commit must be prefixed with the
module name, see:

• https://github.com/kamailio/kamailio/blob/master/.github/
  CONTRIBUTING.md#commit-message-format
  https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md#commit-message-format

got it

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#751 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGxwWN0qd-iYuyupIhZ6fXt4W3RT9Xyrks5qhKNogaJpZM4Jnr8L
.

[miconda]

Have you closed because you plan a new pull request? Because I understand that my suggestion didn't fix it, or?

[kelchy]

closed, will create a new pull request

Kelvin Chua

On Fri, Aug 19, 2016 at 3:34 PM, Daniel-Constantin Mierla <
notifications@github.com> wrote:

Have you closed because you plan a new pull request? Because I understand
that my suggestion didn't fix it, or?

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#751 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGxwWBsOCbARs7j-vdZvfvEiduIpO21oks5qhVyigaJpZM4Jnr8L
.