4.3 #758
Closed
4.3 #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used <CTRL> <SHIFT> F inside Eclipse Mars.2 to format all files and code to be the same.
As requested by oej on Issue #580 terminated all LM_-based messages with a new line (\n) character.
I needed to add some additional debug statements to the code in certain areas due to the issue with the seize line on calls. Even though it does not seem to be giving me all the debug statements in the log file, I do know that the code is executing. Also, it maybe because some of the LM_-based statements did not end with a line terminator.
Just adding a few more.
disappear. Reversing the from and to variables in the sca_dialog_build_from tags call the a inbound call that was put on hold and then seize held by another SCA work without extra appearances showing up.
It states in the code of sca_call_info_is_line_seize_reinvite that if the from and to URI's are the same, then a reINVITE is occuring. Well this was taking any 200 reply and changing the owner and appearance uri to the wrong things. This also cleared up outbound calls to be placed and hold and then seized by another phone without multiple appearances showing up.
When using 'kamcmd sca.all_appearances' to display the appearances the owner and the callee became the same. I think the owner should be a SCA endpoint of the call and not a non-SCA endpoint. This change fixed that issue.
|
Thank you for willing to contribute to kamailio project. You will need to refactor a bit your pull request in order to merge it because we have some rules in order to keep the history of commits clean and coherent:
Same note about contributing are in the repository at: |
|
Closing because I was using the wrong branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Terminated all LM_-based statement messages with new line characters