New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sca: terminate all error and debug messages with a new line #762
Conversation
- issue reported by oej, GH #580 also whitespace cleanup
I see the file utils/kamctl/mysql/ims_dialog-create.sql being also changed. Was is automatically generated? |
Must of been. I did not even touch that. |
I did a simple pull request to make sure I was conforming to the standards. Thank you for showing me that doc. |
- issue reported by oej, GH #580. Modparam outbound_proxy was defined in sca.c and sca.h but never used in the module.
Committing changes that you are not aware of it's not a good thing, because it can break exiting code. Somehow you changed ims_dialog-create.sql and if we don't know why you did it, then it cannot be merged. You can use "git status" before any commit to see what files are affected by the commit. Regarding the removal of outbound_proxy, I see that it was set in a structure. Have you checked that the structure is not passed to the dependency modules like tm, sl where the field might be used? |
Thanks! I pushed the pull request manually on your behalf to get the end result of it (commit c1e0ba6), avoiding changing and reverting other files. You can push the other patches you have for sca module as new pull requests. |
Reported by oej GH #580. Includes whitespace cleanup and normalizing.