Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_client Terminate exported commands list #798

Merged
merged 1 commit into from Sep 26, 2016

Conversation

osthyvel
Copy link

The list of exported functions was not terminated, which caused a
segfault in find_mod_export_record() when reading outside the list.

The list of exported functions was not terminated, which caused a
segfault in find_mod_export_record() when reading outside the list.
@miconda
Copy link
Member

miconda commented Sep 26, 2016

Thanks!

@miconda miconda merged commit 3a6a8b6 into kamailio:master Sep 26, 2016
@oej
Copy link
Member

oej commented Sep 26, 2016

Thanks for finding that out. My test module did not crash - can you elaborate how you read outside of the list? Wan't to learn so we can prevent it from happening again.

@osthyvel
Copy link
Author

I found the issue when moving from CentOS 6 -> 7. I don't know why we didn't see the issue on CentOS6 but it is probably due to placement of the global data in memory. In the CentOS6 build of the http_client (latest from master branch) we were lucky/unlucky to get a 0 in the memory just after the exported functions array when iterating in function find_mod_export_record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants