presence: allow control of subscription deletion #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use the configuration xavp to control subscription deletion after notify searches for `delete_subscription` value in the configuration xavp
|
You have to add the description in the docs for the new attribute. |
|
@miconda added documentation. would like to backport this to 4.4 |
|
this pull requests represents a changing behaviour and in principle shouldn't be in 4.4, but we do have some contraints controlling the deletion of subscriptions. with this pull request we can manage a threshold of notify failures and delete the subscription based on that threshold. |
|
Thanks! I can be merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the configuration xavp to control subscription deletion after notify
searches for
delete_subscriptionvalue in the configuration xavp