Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db_text: implement fetch and memory constraints #940

Merged
merged 1 commit into from Jan 18, 2017
Merged

Conversation

lazedo
Copy link
Contributor

@lazedo lazedo commented Jan 18, 2017

when dealing with large db_text files, pkg_memory is not suitable for
operating the database.

implementing fetch allows modules like presence & registrar & usrloc
to query large tables without constraints on pkg_memory.

creates tmp tables in shared memory for query results

when dealing with large db_text files, pkg_memory is not suitable for
operating the database.

implementing fetch allows modules like presence & registrar & usrloc
to query large tables without constraints on pkg_memory.

creates tmp tables in shared memory for query results
@lazedo
Copy link
Contributor Author

lazedo commented Jan 18, 2017

this pull requests represents a changing behaviour and in principle shouldn't be in 4.4, but db_text is unusable in 4.4 with large db_text files, so i consider this as a fix for the stable branch

@miconda
Copy link
Member

miconda commented Jan 18, 2017

For clarification: with new features we mainly refer to new functions/parameters to configuration file or rpc commands as well as how the configuration file is interpreted. Reworking a part of code in a module is not always a new feature, to be discussed from case to case, evaluating the impact on the other modules.

I understand where the problem is with large dbtext tables + pkg memory and that this can be a fix. I am fine with merging and backporting.

@lazedo lazedo merged commit fafbc5c into 4.4 Jan 18, 2017
@lazedo lazedo deleted the lazedo/db_text_fetch branch January 18, 2017 13:23
@lazedo
Copy link
Contributor Author

lazedo commented Jan 18, 2017

@miconda awesome! thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants