Create ktls_no_curl #942
Merged
Create ktls_no_curl #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nothing big, but I feel like the naming of the group is upside down. We try to use a name to reflect a bit what it contains. I see the new group name as saying what it doesn't contain. What do you think about using ktls_basic ? |
Create ktls_basic group to be able to compile ktls module when curl is not available Signed-off-by: Fabrice Fontaine <fabrice.fontaine@orange.com>
|
You're perfectly right, thanks for this suggestion. I will update the PR accordingly. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create ktls_no_curl group to be able to compile ktls module when curl is
not available
Signed-off-by: Fabrice Fontaine fabrice.fontaine@orange.com