fix - dummy dialog rfc4235 #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandstream validates the dialog and according to rfc4235 the id element is mandatory
|
please @lazedo follow the https://www.kamailio.org/wiki/devel/git-commit-guidelines Something like: presence_dialoginfo: obey rfc4235 adding id element for dummy dialog |
|
you're right, missed the "presence_dialoginfo : " From: sr-dev [sr-dev-bounces@lists.sip-router.org] on behalf of Victor Seva [notifications@github.com] please @lazedohttps://github.com/lazedo follow the https://www.kamailio.org/wiki/devel/git-commit-guidelines Something like: presence_dialoginfo: obey rfc4235 adding id element for dummy dialog — |
rcolobong
pushed a commit
to SIPfoundry/kamailio
that referenced
this pull request
Sep 19, 2017
… presence - Use highest version if multiple subscription found - Change publish e-tag generation for bla
rcolobong
pushed a commit
to SIPfoundry/kamailio
that referenced
this pull request
Sep 19, 2017
… presence - Update changes to notify and presence not included on previous commit
rcolobong
pushed a commit
to SIPfoundry/kamailio
that referenced
this pull request
Sep 27, 2017
… presence - Handle version sync on multiple dialog event under SUBSCRIBE instead in NOTIFY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grandstream validates the dialog and according to rfc4235 the id element is mandatory