tm: deep cloning of the request for fake environment #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems ok to me. |
|
@linuxmaniac, @grumvalski - wondering if you had any time running some tests with the patch, just to have a feeling if you observed any side effect. I didn't get to review yet, planning to do it during the next days. |
|
I did test with our scenarios, I didn't detect any side effect |
|
Can be merged and backported to 5.0, eventually later to 4.4. Probably the deep cloning from acc makes no longer sense, I will check that myself, for now should be harmless. |
|
Sorry for the late feedback. I did try it with some of our suspend scenarios and I haven't noticed side effects. No load though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.