This repository has been archived by the owner on Dec 25, 2019. It is now read-only.
added test runner in top directory and edited settings and init to allow... #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low load configuration for tests
|
Related #57 |
|
This looks great so far! I'd suggest a few changes:
Thanks for your contribution! |
…that gae mini profiler is loaded inly in development and not in testing, added unittest2 to dependencies
kamalgill
added a commit
that referenced
this pull request
Nov 2, 2013
added test runner in top directory and edited settings and init to allow...
|
Thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... loading configuration for tests.
I needed to make changes in init and settings.py it because I had completely different settings for tests and for development and production, so I decided it might be easier to load configuration from objects depending on environment variable. This is the way which is recommended in Flask documentation.
Hope this helps somehow!