Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix click behavior on mobile devices #67

Merged
merged 2 commits into from Mar 11, 2019
Merged

Fix click behavior on mobile devices #67

merged 2 commits into from Mar 11, 2019

Conversation

jmastr
Copy link
Contributor

@jmastr jmastr commented Mar 11, 2019

No description provided.

Julian Vega added 2 commits March 11, 2019 11:20
Fix click behavior on mobile devices
7f5e92d 
Without this patch a user has to click twice on mobile device, so that
his/her rating gets accepted. This is is because the first click event
is captured by hover().

On a mobile device the hover event does not make that much sense, so we
just ignore it.

Closes #34, #51
Fix indentation
174cf7e 
For better readabilty of the diff, the last commit had an incorrect
indentation.
@kamalkhan kamalkhan merged commit 17a355b into surveywp:master Mar 11, 2019
@kamalkhan
Copy link
Contributor

Thank you.

kamalkhan added a commit that referenced this pull request Mar 11, 2019
@kamalkhan
Merges #65 #66 #67. Release 2.6.2.
8a23225
@kamalkhan kamalkhan mentioned this pull request Mar 14, 2019
Closed
@Nio-av
Copy link
Contributor

Nio-av commented Mar 15, 2019 •
edited

See:
https://wordpress.org/support/topic/bug-report-on-first-hover-no-animation-not-clickable/

I also still have troubles. (iOS 12.1.4; but also in Lambda Test & virtual devices (iOS & Android). It is not possible to add Stars. But I'm not quite sure, wether this error caused of NGINX and Google Pagespeed Module or from the PlugIn. I'll test it on an other Server today.

@kamalkhan , Does the last update upload on WordPress.org includes the full merge?
@jmastr , is everything working for you? What is your Server Configuration?

@jmastr
Copy link
Contributor Author

jmastr commented Mar 15, 2019

@Nio-av I can rate from a real iOS 12.4.1 device. However, the js.min.js was cached during my development, so I had to clear my Safari cache to get rid of the double clicking bug. I use a pretty standard Apache setup. You can try to rate something here from your iOS: https://www.veggi.es

@Nio-av
Copy link
Contributor

Nio-av commented Apr 1, 2019

I found my error: There was an other HTML-Element placed aboth the kk Star Rating Element. So, a small change of z-index fixed everything. Thanks for your Help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmastr @kamalkhan @Nio-av