Fix: "At least one of ratingCount or reviewCount is required." #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially if you enable the plugin with Google Rich Snippet support and you don't have any reviews yet the markup is not valid. The AggregateRating object is created, but it has two missing required fields: - Field ratingValue may not be empty. - At least one of ratingCount or reviewCount is required. If we have no score yet, we do not create the AggregateRating object at all. Closes #64
|
Thank you. |
kamalkhan
added a commit
that referenced
this pull request
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially if you enable the plugin with Google Rich Snippet support and
you don't have any reviews yet the markup is not valid. The
AggregateRating object is created, but it has two missing required
fields:
If we have no score yet, we do not create the AggregateRating object at
all.
Closes #64