-removed sending the response from its destructor;

kamchatka-volcano · Jul 8, 2023 · c6b1d00 · c6b1d00
1 parent 4b3b291
commit c6b1d00
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 17 deletions.
diff --git a/include/fcgi_responder/response.h b/include/fcgi_responder/response.h
@@ -16,14 +16,6 @@ class Response{
     ///
     explicit Response(ResponseSender sender);
 
-    ///
-    /// \brief Destructor
-    /// calls the send() method
-    ///
-    ~Response();
-    Response(Response&&) noexcept;
-    Response& operator=(Response&&) noexcept;
-
     ///
     /// \brief setData
     /// Sets HTTP response data

diff --git a/src/response.cpp b/src/response.cpp
@@ -7,14 +7,6 @@ Response::Response(ResponseSender sender)
 {
 }
 
-Response::~Response()
-{
-    send();
-}
-
-Response::Response(Response&&) noexcept = default;
-Response& Response::operator=(Response&&) noexcept = default;
-
 void Response::send()
 {
     if (!sender_)

diff --git a/tests/test_responder.cpp b/tests/test_responder.cpp
@@ -30,9 +30,10 @@ class MockResponder : public Responder{
     MOCK_METHOD1(sendData, void(const std::string& data));
     MOCK_METHOD0(disconnect, void());
     MOCK_METHOD1(doProcessRequest, void(const Request& request));
-    void processRequest(Request&& request, Response&&) override
+    void processRequest(Request&& request, Response&& response) override
     {
         doProcessRequest(request);
+        response.send();
     }
 
     void receive(const std::string& data)
@@ -50,6 +51,7 @@ class MockResponderWithTestProcessor : public Responder{
         auto testMsg = request.stdIn();
         std::reverse(testMsg.begin(), testMsg.end());
         response.setData(testMsg);
+        response.send();
     }
     void receive(const std::string& data)
     {