Remove useless comparision of packet header's length with itself #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was one of the items flagged by the PVS-Studios tool: http://www.viva64.com/en/b/0377/
|
Thanks for the patch. this repository tree is not maintained anymore and just kept for the record. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was one of the items flagged by the PVS-Studios tool:
http://www.viva64.com/en/b/0377/
Maybe, the header-length was meant to be compared with the message-length (m->m_len) -- such as to ensure, the message consists of nothing but header? Don't know -- but the current code, faithfully copied by both NetBSD and FreeBSD, makes no sense. I can not find this part in OpenBSD at all...
It would also seem, the function's second argument (socket) could use
const-qualifier. The function-describing comment could stand English-grammar fixes too.