Use parseFloat for hsla arguments, which usually use the % character

kamicane · Aug 9, 2012 · e2f07dc · e2f07dc
1 parent c2032d0
commit e2f07dc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/color.js b/lib/color.js
@@ -67,10 +67,10 @@ var HUEtoRGB = function(p, q, t){
 var HSLtoRGB = function(h, s, l, a){
     var r, b, g
     if (a == null || a === "") a = 1
-    h /= 360
+    h = parseFloat(h) / 360
-    s /= 100
+    s = parseFloat(s) / 100
-    l /= 100
+    l = parseFloat(l) / 100
-    a /= 1
+    a = parseFloat(a) / 1
     if (h > 1 || h < 0 || s > 1 || s < 0 || l > 1 || l < 0 || a > 1 || a < 0) return null
     if (s === 0){
         r = b = g = l

diff --git a/test/test.parsers.js b/test/test.parsers.js
@@ -75,6 +75,7 @@ describe('CSS Parsers', function (){
         expect(moofx.parse('color', "rgb(0,0,0)")).to.be("rgb(0,0,0)")
         expect(moofx.parse('color', "#ff330099")).to.be("rgba(255,51,0,0.6)")
         expect(moofx.parse('color', "#f309")).to.be("rgba(255,51,0,0.6)")
+        expect(moofx.parse('color', "hsla(0,0%,100%,0.3)")).to.be("rgba(255,255,255,0.3)")
 
         // normalized
         expect(moofx.parse('color', "", true)).to.be("rgba(0,0,0,1)")