ApolloClient does not delay the application becoming stable #2252
Conversation
🦋 Changeset detectedLatest commit: 7f97c31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
💻 Website PreviewThe latest changes are available as preview in: https://37055265.apollo-angular.pages.dev |
Otherwise, we might encounter a delay of 10 seconds, and this might lead to suboptimal experience as described in https://angular.io/errors/NG0506 Fixes #2251
|
@diesieben07, thanks for the reproduction case. I can see from https://angular.io/errors/NG0506 that #2251 unnecessarily delays DOM clean up. While I am not quite sure this could have such an catastrophic effect, we might as well avoid it by following your suggestion. You would you mind testing the alpha release in your real-world project and report if everything goes smoothly via |
|
@PowerKiKi Thank you for the prompt fix. The problem no longer occurs in our (internal) real world project with |
Because ApolloClient is created outside of NgZone
|
Thank you, works great! |
Otherwise, we might encounter a delay of 10 seconds, and this might lead to suboptimal experience as described in https://angular.io/errors/NG0506
Fixes #2251