Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom tsconfig path for the build command #190

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Custom tsconfig path for the build command #190

merged 4 commits into from
Feb 15, 2023

Conversation

enisdenjo
Copy link
Collaborator

@enisdenjo enisdenjo commented Jan 25, 2023

The tsconfig.json file is implicitly read to inherit tsc options during the build phase.

However, sometimes you might have multiple config files and use one for build. One common reason is one tsconfig checks the types of all files (including other configs and tests) and another tsconfig specifies what is to be built.

This PR allows for a --tsconfig option to directly specify the tsconfig to use.

TODO

  • Tests

@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2023

🦋 Changeset detected

Latest commit: d7c4ed6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
bob-the-bundler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 25, 2023

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
bob-the-bundler 5.1.0-alpha-20230126161914-54dd016 npm ↗︎ unpkg ↗︎

@enisdenjo enisdenjo force-pushed the tsconfig-path branch 2 times, most recently from f0abaf4 to b508a86 Compare January 26, 2023 14:42
@enisdenjo
Copy link
Collaborator Author

Do you guys think b508a86 should be flagged a breaking change?

@n1ru4l
Copy link
Collaborator

n1ru4l commented Jan 26, 2023

Not sure why we should do tsconfig.build.json by default. I like to keep things simple and having multiple tsconfigs should be avoided. I don't care about a slightly longer build time because of test type checking - wouldn't we solve it anyways with the incremental flag?

@enisdenjo
Copy link
Collaborator Author

The idea is to keep bob opinionated and thereby speed up the necessary setup, would require less arguments with tsconfig.build.json as the default.

@n1ru4l n1ru4l merged commit ae4b2ef into master Feb 15, 2023
@n1ru4l n1ru4l deleted the tsconfig-path branch February 15, 2023 08:03
n1ru4l added a commit that referenced this pull request Feb 15, 2023
@enisdenjo enisdenjo restored the tsconfig-path branch February 15, 2023 08:14
@enisdenjo
Copy link
Collaborator Author

Re-opened in #202.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants