Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept both /supergraph and / CDN url for apollo-router #3309

Closed
n1ru4l opened this issue Nov 7, 2023 · 0 comments · Fixed by #4484
Closed

accept both /supergraph and / CDN url for apollo-router #3309

n1ru4l opened this issue Nov 7, 2023 · 0 comments · Fixed by #4484
Labels
enhancement New feature or request that adds new things or value to Hive good first issue Good for newcomers help wanted Extra attention is needed

Comments

@n1ru4l
Copy link
Collaborator

n1ru4l commented Nov 7, 2023

Right now we append /supergraph to the CDN "base" endpoint, which confused people a lot. Instead, people should directly pass the URL with /supergraph appended. For the transition period, we can accept both and check whether the URL ends with /supergraph and if not so, automatically append /supergraph to it.
@n1ru4l n1ru4l added the enhancement New feature or request that adds new things or value to Hive label Nov 7, 2023
@n1ru4l n1ru4l added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 17, 2024
@theguild-bot theguild-bot mentioned this issue Jan 24, 2024
Open
92 tasks
kamilkisiela added a commit that referenced this issue Apr 10, 2024
@kamilkisiela
CDN endpoints with and without /artifact-type part
e50c879 
Fixes #3309
@kamilkisiela kamilkisiela mentioned this issue Apr 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request that adds new things or value to Hive good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CDN endpoints with and without /artifact-type part kamilkisiela/graphql-hive
1 participant
@n1ru4l