Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only allow CDN access with the correct access key #147

Merged
merged 9 commits into from Jun 19, 2022
Merged

fix: only allow CDN access with the correct access key #147

merged 9 commits into from Jun 19, 2022

Conversation

n1ru4l
Copy link
Collaborator

@n1ru4l n1ru4l commented Jun 19, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jun 19, 2022 •
edited

⚠️ No Changeset found

Latest commit: 1a3f624

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@n1ru4l n1ru4l changed the title test: check whether cdn can be accessed with an invalid token fix: only allow CDN access with the correct access key Jun 19, 2022
@n1ru4l
Copy link
Collaborator Author

n1ru4l commented Jun 19, 2022

@dotansimha Note: the tests are still failing.

@dotansimha dotansimha mentioned this pull request Jun 19, 2022
Closed
@dotansimha dotansimha merged commit faebda1 into main Jun 19, 2022
@dotansimha dotansimha deleted the test-cdn-invalid-token branch June 19, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotansimha dotansimha dotansimha approved these changes

@kamilkisiela kamilkisiela Awaiting requested review from kamilkisiela

@saihaj saihaj Awaiting requested review from saihaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@n1ru4l @dotansimha