Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for data key in Introspection diff #2059

Closed
wants to merge 10 commits into from

Conversation

tvvignesh
Copy link
Contributor

Description

Addressing feedback from @AllexVeldman here: #2054 (comment) with respect to allowing optional data key during introspection.

Fixes #2054 (comment)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Jan 2, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/theguild/graphql-inspector/6opKAXa2TjnKX46ffHnfqMc9vQLD
✅ Preview: https://graphql-inspector-git-fork-tvvignesh-introspect-8ab149-theguild.vercel.app

@tvvignesh tvvignesh changed the title Introspection support Allow for data key in Introspection diff Jan 2, 2022
@tvvignesh tvvignesh mentioned this pull request Jan 2, 2022
12 tasks
@AllexVeldman
Copy link

@kamilkisiela Is there anything we need to do to advance this PR?

@tvvignesh tvvignesh closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants