Skip to content
This repository has been archived by the owner on May 11, 2022. It is now read-only.
This repository has been archived by the owner on May 11, 2022. It is now read-only.

external configuration for router #83

Closed
kamilsk opened this issue Mar 16, 2018 · 2 comments
Closed

external configuration for router #83

kamilsk opened this issue Mar 16, 2018 · 2 comments
Assignees
Milestone

Comments

@kamilsk
Copy link
Member

kamilsk commented Mar 16, 2018

add a possibility to configure route external

as example

	if withProfiler {
		r.Route("/debug/pprof", func(r chi.Router) {
			r.Get("/", pprof.Index)
			r.Get("/cmdline", pprof.Cmdline)
			r.Get("/profile", pprof.Profile)
			r.Get("/symbol", pprof.Symbol)
			r.Get("/trace", pprof.Trace)
		})
	}

this is a not a part of chi router, also as expvar.

@kamilsk kamilsk added this to the form-api 1.0 milestone Mar 16, 2018
@kamilsk kamilsk self-assigned this Mar 16, 2018
@kamilsk
Copy link
Member Author

kamilsk commented Mar 17, 2018

use specification instead, like

{http.Get, "/api/v1/path"},
{http.Post, "/api/v1/path"},
{http.Get, "/debug/pprof"},
etc.

@kamilsk kamilsk modified the milestone: form-api 1.0 Mar 27, 2018
@kamilsk
Copy link
Member Author

kamilsk commented Mar 30, 2018

will not do, but specification is good part, it will be done by #16

@kamilsk kamilsk closed this as completed Mar 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant