Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lint issues and coverage report #161

Closed
kamilsk opened this issue Jan 3, 2021 · 0 comments
Closed

fix lint issues and coverage report #161

kamilsk opened this issue Jan 3, 2021 · 0 comments
Assignees
Milestone

Comments

@kamilsk
Copy link
Owner

kamilsk commented Jan 3, 2021

example_test.go:42:3: exitAfterDefer: log.Fatal clutters `defer cancel()` (gocritic)
		log.Fatal(err)
		^
retry_test.go:65:44: SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
		ctx := context.WithValue(context.TODO(), "test", "value")
		                                         ^
retry_test.go:140:44: SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)
		ctx := context.WithValue(context.TODO(), "test", "value")
		                                         ^
$ if [[ $TRAVIS_GO_VERSION == 1.15* ]]; then
    cc-test-reporter after-build -t gocov -p $(go list -m) --exit-code $TRAVIS_TEST_RESULT
fi
  
time="2021-01-03T11:26:18Z" level=error msg="failed to read file v5/backoff/backoff.go\nopen v5/backoff/backoff.go: no such file or directory" 
Error: open v5/backoff/backoff.go: no such file or directory
@kamilsk kamilsk added this to the retry 5.0 milestone Jan 3, 2021
@kamilsk kamilsk self-assigned this Jan 3, 2021
kamilsk added a commit that referenced this issue Jan 8, 2021
kamilsk added a commit that referenced this issue Jan 8, 2021
kamilsk added a commit that referenced this issue Jan 8, 2021
@kamilsk kamilsk closed this as completed in 2c165a1 Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant