Subclasses are including ActiveRecordModelExtension too fast #262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In regard of this issue: https://github.com/amatsuda/kaminari/pull/119
Everything works fine, unless you want to change the configuration of Kaminari (for example change the page_method_name)
I'm using paper_trail in project, but I'm also kind of forced to change the page_method_name.
First paper_trail is loaded, then kaminari after ActiveSupport loads, then all 'subclasses' are having ActiveRecordModelExtension included, right with Version model which is provided by paper_trail, but unfortunately the extensions are loaded before the configuration file from project is loaded, therefore, Version model has default kaminari config, while other projects model have proper config.
I've changed active_record_extension to load subclasses when first model is 'loaded' in project.