Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get specs running under Rubinius #489

Merged
merged 1 commit into from Dec 15, 2013
Merged

Get specs running under Rubinius #489

merged 1 commit into from Dec 15, 2013

Conversation

petergoldstein
Copy link
Contributor

  1. Added Rubinius gems to Gemfiles.
  2. Updated Rakefile to handle Rubinius/Rails 4 case where RDocTask is not available.

Almost all of the test matrix is green with this PR. There is still one failure - ActiveRecord edge + Rubinius. This appears to be the result of a recently introduced incompatibility. I'm not sure how to fix it. But the remaining Rubinius specs all run as expected now.

amatsuda added a commit that referenced this pull request Dec 15, 2013
@amatsuda amatsuda merged commit 46300c3 into kaminari:master Dec 15, 2013
@amatsuda
Copy link
Member

@petergoldstein Wow! Awesome work! Thank you! ⚡ ⚡ ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants