[WIP] Migrate to Rust 2018

[cjbassi]

This will likely have merge conflicts with some of the other PRs, so I think it would be best to merge those first and then we can come back and fix this

[kamiyaa]

I am holding back on merging this currently because of jeaye/ncurses-rs#180 causing unicode to not display properly.

[cjbassi]

Doesn't rust2018 only require 1.31.0?

[kamiyaa]

Hmm, I'm getting errors when compiling on rustc 1.31.0 (abe02cefd 2018-12-04)

error[E0658]: imports can only refer to extern crate names passed with `--extern` on stable channel (see issue #53130)                            
  --> src/joshuto.rs:19:5                                                                                                                         
   |                                                                                                                                              
6  | pub mod config;                                                                                                                              
   | --------------- not an extern crate passed with `--extern`                                                                                   
...                                                                                                                                               
19 | use config::JoshutoTheme;                                                                                                                    
   |     ^^^^^^                                                                                                                                   
   |                                                                                                                                              
note: this import refers to the module defined here                                                                                               
  --> src/joshuto.rs:6:1                                                                                                                          
   |                                                                                                                                              
6  | pub mod config;                                                                                                                              
   | ^^^^^^^^^^^^^^^                                                                                                                              
                                                                                                                                                  
error[E0658]: imports can only refer to extern crate names passed with `--extern` on stable channel (see issue #53130)                            
  --> src/joshuto.rs:20:5                                                                                                                         
   |                                                                                                                                              
6  | pub mod config;                                                                                                                              
   | --------------- not an extern crate passed with `--extern`                                                                                   
...                                                                                                                                               
20 | use config::JoshutoMimetype;                                                                                                                 
   |     ^^^^^^                                                                                                                                   
   |                                                                                                                                              
note: this import refers to the module defined here                                                                                               
  --> src/joshuto.rs:6:1                                                                                                                          
   |                                                                                                                                              
6  | pub mod config;                                                                                                                              
   | ^^^^^^^^^^^^^^^                                                                                                                              
                                                                                                                                                  
error[E0658]: imports can only refer to extern crate names passed with `--extern` on stable channel (see issue #53130)                            
  --> src/joshuto.rs:21:5                                                                                                                         
   |                                                                                                                                              
9  | mod context;                                                                                                                                 
   | ------------ not an extern crate passed with `--extern`                                                                                      
...                                                                                                                                               
21 | use context::JoshutoContext;                                                                                                                 
   |     ^^^^^^^                                                                                                                                  
   |                                                                                                                                              
note: this import refers to the module defined here                                                                                               
  --> src/joshuto.rs:9:1                                                                                                                          
   |                                                                                                                                              
9  | mod context;                                                                                                                                 
   | ^^^^^^^^^^^^                                                                                                                                 
                                                                                                                                                  
error[E0658]: imports can only refer to extern crate names passed with `--extern` on stable channel (see issue #53130)                            
  --> src/joshuto.rs:22:5                                                                                                                         
   |                                                                                                                                              
8  | mod command;                                                                                                                                 
   | ------------ not an extern crate passed with `--extern`                                                                                      
...                                                                                                                                               
22 | use command::CommandKeybind;                                                                                                                 
   |     ^^^^^^^                                                                                                                                  
   |                                                                                                                                              
note: this import refers to the module defined here                                                                                               
  --> src/joshuto.rs:8:1                                                                                                                          
   |                                                                                                                                              
8  | mod command;                                                                                                                                 
   | ^^^^^^^^^^^^                                                                                                                                 
                                                                                                                                                  
error[E0658]: imports can only refer to extern crate names passed with `--extern` on stable channel (see issue #53130)                            
  --> src/joshuto.rs:23:5                                                                                                                         
   |                                                                                                                                              
8  | mod command;                                                                                                                                 
   | ------------ not an extern crate passed with `--extern`                                                                                      
...                                                                                                                                               
23 | use command::JoshutoCommand;                                                                                                                 
   |     ^^^^^^^                                                                                                                                  
   |                                                                                                                                              
note: this import refers to the module defined here                                                                                               
  --> src/joshuto.rs:8:1                                                                                                                          
   |                                                                                                                                              
8  | mod command;                                                                                                                                 
   | ^^^^^^^^^^^^                                                                                                                                 
                                                                                                                                                  
error: aborting due to 5 previous errors  

[kamiyaa]

Is it okay that I close this? There are conflicts so I added Rust 2018 to dev branch because there seems to be a fix for ncurses-rs on rust-1.32+

[cjbassi]

Yah, glad 1.32 is working now. And I realized you can just do cargo fix --edition which applies most of these changes anyway.