Merge pull request #10 from mladens/respBodyLeak

Consume response body for all cases
kamon-io · Sep 3, 2018 · bfe3895 · bfe3895
2 parents 89e6c3d + 6970821
commit bfe3895
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/main/scala/kamon/kamino/KaminoApiClient.scala b/src/main/scala/kamon/kamino/KaminoApiClient.scala
@@ -61,14 +61,15 @@ class KaminoApiClient(config: KaminoConfiguration) {
 
     def parseResponse(response: Response): Try[IngestionResponse] = Try {
       val respBuilder = IngestionResponse.newBuilder()
+      val body = response.body().bytes()
       response.code() match {
         case 200 =>
           respBuilder
             .setStatus(OK)
             .build()
-        case 490 =>
+        case 490 if body.nonEmpty =>
           IngestionResponse
-            .parseFrom(response.body().bytes())
+            .parseFrom(body)
         case _ =>
           respBuilder
             .setStatus(IngestionStatus.ERROR)