-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
will this work for akka 2.3 and scala 2.11? #34
Comments
Scala 2.11 is not binary compatible with Scala 2.10.x, so I guess it wont work at all.. there have been a couple requests from people trying to use Scala 2.11 so we will probably make a release in the following days. I'll let you known when it is out! |
Thanks..Will be waiting on this. |
+1 for that. Kamon is the only dependency that I have right now that doesn't play well with Scala 2.11. |
@adrien-aubel that sounds like you are already using Kamon for some time! It would be nice if you can share a bit of you experience with us.. in the meantime, the Scala 2.11 support just gained a couple priority points, I'll get back to you guys soon. |
@jahangirmohammed @adrien-aubel I just published Kamon 0.3.1-5a87b76817433b7d2997bcbbe3d9173a6f6a1055 for Scala 2.11 in our snapshots repository, just in case you guys want to try it out before our next release is available. From now on we will publish releases for Scala 2.11 as well. Have fun! |
That's cool man. Testing it right now. For example I see this:
As two different transactions. I'd love to see only one transaction showing up in New Relic, like this for example:
But I'm not sure of the changes it would imply on your side. |
I get this exception when starting tests:
I use spray |
@adrien-aubel thanks for testing this out! First, regarding your web transactions name, what you currently see is the default name that Kamon sets for a "automatically generated Trace", but you can change the name if you want to. There is a traceDirective that allows you to do just that, and ideally you will give a transaction a more meaningful name.. a example based on your case might be:
That should solve your first problem, in a few minutes will try out the NCDFE. |
@adrien-aubel I just tried to run one of our toy apps and everything is working just fine.. could you please review that your classpath contains spray-json 1.2.6? Is it possible that you excluded it from your classpath because you are using play-json and it just seemed to be unnecessary? Kamon uses it when posting data to New Relic. |
Oh yeah you're right, I've put this in my dependencies:
because otherwise the Spray version would clash with the one compatible with Scala 2.11. They're busy at Spray / Typesafe making of Spray the new akka-http, but it's also part of a bigger plan (Reactive Streams), so the situation right now around Spray is kind of complicated. I'll tweak the dependencies and get back to you if I don't succeed. Thanks for the help, I really appreciate that. |
Nice! the snapshot you are using depends on Spray |
thanks a ton for this - @ivantopo ..Will try out.. |
Thanks @ivantopo I removed the dependency exclusion and it's working great! Just one last thing: is there anything special to be done to have the error rates (HTTP 4xx and 5xx) correctly showing up on New Relic? |
There is a NewRelicErrorLogger that takes all |
I see. I'll test it, and I'm looking forward for any improvement in this class. |
So I tested today this with a small amount of our users in production. For some reason I see a lot of occurrences this exception, that wasn't happening with Scala 2.10:
Do you know what could cause this? |
I think that you found a bug, let me check and I'll notice you when I fix best regards. Diego On Thu, Jun 5, 2014 at 7:38 PM, Adrien Aubel notifications@github.com
|
Thanks. Looking forward for it! Let me know if I can help. |
@adrien-aubel I just created #36 to track that bug, it would be nice if you can go there and give us a bit more info, thanks for reporting! |
When can we expect the project work for akka 2.3 and scala 2.11?
The text was updated successfully, but these errors were encountered: