Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoSuchMethodError ActorSystem.shutdown() #459

Closed
swachter opened this issue May 12, 2017 · 12 comments
Closed

NoSuchMethodError ActorSystem.shutdown() #459

swachter opened this issue May 12, 2017 · 12 comments

Comments

@swachter
Copy link

swachter commented May 12, 2017

Kamon.shutdown() uses the deprecated method ActorSystem.shutdown() that is no more available in Akka 2.5.

@rrodseth
Copy link

I'm also hoping to start using Akka 2.5.1, but am dependent on Kamon.

@dpsoft
Copy link
Contributor

dpsoft commented May 19, 2017

Guys we just published a snapshot versión of kamon-core: 0.6.7-469c11dc1ddb140f407a33f48033e533bf60611c that supports akka 2.5.x.

@rrodseth
Copy link

Thanks.

@UriShohet
Copy link

UriShohet commented May 21, 2017

@dpsoft the code for scala 2.11 version still says system.shutdown()...

@jan-pieter
Copy link
Contributor

The called method should not be dependent on the scala version but on the akka version used. The minimum akka version is dependent on the scala version but a newer version might be used.

@jan-pieter
Copy link
Contributor

PR: #460

jan-pieter added a commit to jan-pieter/Kamon that referenced this issue May 22, 2017
dpsoft pushed a commit that referenced this issue May 23, 2017
* [#459] call correct method for shutting down the ActorSystem

* [#459] fix scala 2.10 / akka 2.3 compatibility
@rrodseth
Copy link

Thanks for the 0.6.7 release. I'll try it out as soon as it shows up in Maven Central.

@dpsoft
Copy link
Contributor

dpsoft commented May 23, 2017

@rrodseth
Copy link

Thanks. I'm on 2.11 but I can/should probably update this particular app.

@rrodseth
Copy link

Oh, I see core is there, but
The following artifacts could not be resolved: io.kamon:kamon-log-reporter_2.11:jar:0.6.7, io.kamon:kamon-system-metrics_2.11:jar:0.6.7, io.kamon:kamon-statsd_2.11:jar:0.6.7, io.kamon:kamon-datadog_2.11:jar:0.6.7: Failure to find io.kamon:kamon-log-reporter_2.11:jar:0.6.7

@dpsoft
Copy link
Contributor

dpsoft commented May 23, 2017

Please only change kamon-core.

@rrodseth
Copy link

So far so good. Was able to update core only and do

       CoordinatedShutdown(system).addTask(CoordinatedShutdown.PhaseActorSystemTerminate, "shutdownKamon") { () =>
        println(s"Shutting down Kamon with coordinated shutdown")
        Kamon.shutdown()
        Future.successful(Done)
      } 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants